PEP632: Remove depracted call of distutils.version.LooseVersion #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g.version.Version
adrinjalali
reviewed
Apr 25, 2022
|
Python 3.12 support has been added to scikit-learn, see scikit-learn/scikit-learn#27027. So this would be the first step towards supporting py3.12 with the latest sklearn 1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am sorry for the short PR yesterday, but I got interrupted. So my concern is that import scikit-learn-extra in a pytest environment leads to raising warnings. I need to admit, that I am not able to reproduce a minimal working example.
I would suggest to remove the depracted call of
distutils.version.LooseVersionwithpackaging.version.Version. The reason is that starting from Python 3.12 thedistutilspackage will be removed, see PEP634. In thepackagingmodule there is noLooseVersion, but regarding the strict versioning ofsklearnandnumpythis should make no difference.PS: I've just notice that it is checked against version below the
INSTALL_REQUIRES. So it should be save deleting these checks completely.scikit-learn-extra/setup.py
Line 24 in cb70ef0